Fix RTL lint errors and Verilator warnings#14
Open
JinMaimagine wants to merge 1 commit intomasterfrom
Open
Conversation
- Remove invalid Verilator warning flags (GENUNNAMED, EOFNEWLINE, WIDTHTRUNC, WIDTHEXPAND) - Consolidate width warnings to -Wno-WIDTH, add -Wno-MULTITOP suppression - Add include guards to para_pkg.sv to prevent multiple inclusions - Create common_helpers.sv with shared helper modules (ha, fa, Four2Two) - Update mult_INT4.sv and mult_INT8.sv to use shared includes instead of duplicates - Add lint target to Makefile for easier testing - Clean up generated files (obj_dir/main.cpp, tensorcore.vcd) This resolves duplicate module declarations and invalid warning flags that were causing RTL lint failures in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failing RTL Lint Check job in GitHub Actions by resolving Verilator warning flag issues and duplicate module declarations.
Changes Made
🔧 Verilator Warning Flags Fixed
GENUNNAMED,EOFNEWLINE,WIDTHTRUNC,WIDTHEXPAND(not supported in Verilator 5.006)-Wno-WIDTHflag-Wno-MULTITOPfor multiple top-level modules📦 Code Organization Improvements
para_pkg.svto prevent multiple inclusionscommon_helpers.svwith shared helper modules (ha,fa,Four2Two)mult_INT4.svandmult_INT8.sv🧹 Build System Enhancements
linttarget to Makefile for easier RTL lintingFiles Modified
rtl/verilator/Makefile- Fixed invalid warning flags, added lint targetrtl/util/para_pkg.sv- Added include guardsrtl/util/MAC/mac/common_helpers.sv- NEW: Shared helper modulesrtl/util/MAC/mac/mult_INT4.sv- Removed duplicates, added includertl/util/MAC/mac/mult_INT8.sv- Removed duplicates, added includeTesting
Impact
This PR specifically targets the RTL Lint Check CI job that was failing due to:
The changes are minimal and focused, ensuring compatibility with the existing codebase while resolving the specific linting issues.
Related Issues
Fixes the failing GitHub Actions on PR #13 - specifically the RTL Lint Check job.
@JinMaimagine can click here to continue refining the PR