Added logic to allow Metadata values to be split over several lines#70
Open
Goosse wants to merge 2 commits intoJohnSundell:masterfrom
Open
Added logic to allow Metadata values to be split over several lines#70Goosse wants to merge 2 commits intoJohnSundell:masterfrom
Goosse wants to merge 2 commits intoJohnSundell:masterfrom
Conversation
…y using two spaces on the following lines. In most cases, multiline values already worked except when a colon was intended to be part of the value in one of the following lines. This used to be interpreted as a new key/value pair.
Author
|
As I've thought more about this. I'm not sure this is the best way to go about this. This would cause issues with in the following situation: I might be more appropriate for use quotes around multiline strings like so: And a note on the test linked to in the original pull request (testMergingOrphanMetadataValueIntoPreviousOne). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In most cases, multiline values already worked (see here)except when a colon was intended to be part of the value in one of the following lines. This used to be interpreted as a new key/value pair.
With this change, all lines starting with 2 spaces will be interpreted as part of the value for the previous key, even if there is a colon in the line.