Fixes #82 and #83#84
Open
rsenne wants to merge 4 commits into
Open
Conversation
…on). Also switched inhomogeneous tiem_change to be cumsummed.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…jl into history_fixes_
JoseKling
requested changes
May 11, 2026
| i in 1:(length(edges) - 1) | ||
| ] | ||
| T = eltype(deltas) | ||
| deltas .= max.(zero(T), deltas) |
Owner
There was a problem hiding this comment.
This actually does not guard against errors. If any delta is 0, then we have repeated events.
I guess we should use max(eps(T), deltas) instead. A warning could be useful, maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the default behavior of
History,push!, andappend!to no longer coerce the time of arrivals to be sorted.This in theory will prevent two pathological cases where 1.) a user has data issues they don't know about or 2.) or they merely havent sorted their data. Ideally, this removes the layer of reasoning about the user and their data.
We however, still retain the ability to set
check_args=falsein the event minor numerical errors occur where we may expect them in th ebackend and handle them ourselves.I also tacked on the propsoed chackge to time_change using
cumsumwhich as better design.Also bumps the version of the project. Resolves #82 and resolves #83.