Chore: React 16 compatibility#23
Open
dotcs wants to merge 5 commits intoJosh-ES:masterfrom
dotcs:chore/react-16-compat
Open
Chore: React 16 compatibility#23dotcs wants to merge 5 commits intoJosh-ES:masterfrom dotcs:chore/react-16-compat
dotcs wants to merge 5 commits intoJosh-ES:masterfrom
dotcs:chore/react-16-compat
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have updated some code parts, that broke with React 16.
These are the things I fixed in this PR:
typingstopackage.json(otherwise TypeScript typings are not recognised in consumer)prepublishOnlynpm scriptbuildnpm scriptreact@^16.0.0to peer dependenciesprop-typespackage, becausePropTypeshave been removed in React 16reactandreact-domto dev dependencies, because otherwise tests won't workrefinstead ofReactDOM.findDOMNode, because the latter should be avoided and does not work properly in React 16yarn.lockfilereact-dom/serverIf you want to test the current version with React 16, then you can use
@dotcs/react-here-maps@0.4.1-alpha.1. I have uploaded the fixed package to this npm repository.