Skip to content

fix(repo): fix some zizmor reported issues#2518

Draft
rubiesonthesky wants to merge 6 commits into
JoshuaKGoldberg:mainfrom
rubiesonthesky:github-actions-lint
Draft

fix(repo): fix some zizmor reported issues#2518
rubiesonthesky wants to merge 6 commits into
JoshuaKGoldberg:mainfrom
rubiesonthesky:github-actions-lint

Conversation

@rubiesonthesky

Copy link
Copy Markdown
Collaborator

PR Checklist

Overview

@rubiesonthesky

rubiesonthesky commented May 13, 2026

Copy link
Copy Markdown
Collaborator Author

Testing accessibility bot

@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown

Uh oh! @rubiesonthesky, at least one image you shared is missing helpful alt text. Check #2518 (comment) to fix the following violations:

  • Images should have alternate text (alt text) at line 2

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.42%. Comparing base (2d2861b) to head (ab16269).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2518   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files         169      169           
  Lines        2882     2882           
  Branches      720      720           
=======================================
  Hits         2145     2145           
  Misses        506      506           
  Partials      231      231           
Flag Coverage Δ
mutation 66.72% <ø> (ø)
unit 21.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rubiesonthesky rubiesonthesky marked this pull request as ready for review May 13, 2026 18:31
@rubiesonthesky rubiesonthesky marked this pull request as draft May 13, 2026 18:48
@rubiesonthesky rubiesonthesky added the status: waiting for author Needs an action taken by the original poster label May 19, 2026
@rubiesonthesky rubiesonthesky marked this pull request as ready for review May 19, 2026 20:59
@rubiesonthesky

Copy link
Copy Markdown
Collaborator Author
image

@github-actions

Copy link
Copy Markdown

Uh oh! @rubiesonthesky, at least one image you shared is missing helpful alt text. Check #2518 (comment) to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 1

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
package-manager-cache: false # never use caching in release builds

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question] Why not?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s from here because I started to check how things should be wired up: https://docs.npmjs.com/trusted-publishers#github-actions-configuration

Though this is not mentioned setup-node readme and this repo uses pnpm. So it may be unnecessary setting. I wonder does it actually make any difference, I guess you would want to be sure that the cache has not been poisoned by anything before doing a release.

These actions are little bit unfamiliar for me, so this whole PR is more like testing did I break anything. :)

that’s why I also changed it to non-draft because I need to test the label removing action.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will request a review from you now for testing purposes, it doesn’t mean you need to review this yet! :D

@github-actions github-actions Bot removed the status: waiting for author Needs an action taken by the original poster label May 20, 2026
@rubiesonthesky rubiesonthesky marked this pull request as draft May 20, 2026 14:08
@rubiesonthesky

Copy link
Copy Markdown
Collaborator Author

TODO: The label removal does not work yet, it needs to have GitHub token set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants