fix(repo): fix some zizmor reported issues#2518
Conversation
|
Uh oh! @rubiesonthesky, at least one image you shared is missing helpful alt text. Check #2518 (comment) to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2518 +/- ##
=======================================
Coverage 74.42% 74.42%
=======================================
Files 169 169
Lines 2882 2882
Branches 720 720
=======================================
Hits 2145 2145
Misses 506 506
Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
934fc85 to
ab16269
Compare
|
Uh oh! @rubiesonthesky, at least one image you shared is missing helpful alt text. Check #2518 (comment) to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
| - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 | ||
| with: | ||
| node-version: 22 | ||
| package-manager-cache: false # never use caching in release builds |
There was a problem hiding this comment.
It’s from here because I started to check how things should be wired up: https://docs.npmjs.com/trusted-publishers#github-actions-configuration
Though this is not mentioned setup-node readme and this repo uses pnpm. So it may be unnecessary setting. I wonder does it actually make any difference, I guess you would want to be sure that the cache has not been poisoned by anything before doing a release.
These actions are little bit unfamiliar for me, so this whole PR is more like testing did I break anything. :)
that’s why I also changed it to non-draft because I need to test the label removing action.
There was a problem hiding this comment.
I will request a review from you now for testing purposes, it doesn’t mean you need to review this yet! :D
|
TODO: The label removal does not work yet, it needs to have GitHub token set. |


PR Checklist
status: accepting prsOverview