Skip to content

fix: track Ponder fallback routing as a flag, not a URL comparison #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Danswar wants to merge 1 commit into from
Closed

fix: track Ponder fallback routing as a flag, not a URL comparison #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions api.apollo.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,14 @@ function activateFallback(): void {
}
}

// Stamps each attempt with its target URL so errors are attributed to the URL
// the request was actually sent to, not the routing state at error time.
// Stamps each attempt with the URL it was sent to and whether that was the
// fallback, so errors are attributed to the routing state at SEND time, not
// re-derived from the URL at error time — a bare URL comparison can't tell
// primary from fallback once an operator points the fallback at the same
// host as the primary (the standard way to disable cross-environment
// failover; see CONFIG_INDEXER_FALLBACK_URL in the prd/dev compose files).
const routingLink = new ApolloLink((operation, forward) => {
operation.setContext({ targetUrl: getIndexerUrl() });
operation.setContext({ targetUrl: getIndexerUrl(), usedFallback: isFallbackActive() });
return forward(operation);
});

Expand All @@ -42,7 +46,7 @@ const errorLink = onError(({ graphQLErrors, networkError, operation, forward })

if (networkError) {
const msg = `[Network error in operation: ${opName}] ${networkError.message}`;
const sentToFallback = !!CONFIG.indexerFallback && operation.getContext().targetUrl === CONFIG.indexerFallback;
const sentToFallback = !!operation.getContext().usedFallback;

if (CONFIG.indexerFallback && !sentToFallback) {
// Primary failed and a fallback exists — log at warn so transparent
Expand Down
Loading