Open
Conversation
Member
|
You are correct, and now I don't think the functions confusing you are good to keep. Instead of making this PR, I prefer to talk with you about how to evaluate generated julia code in given module. This is the approach I'd prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to add a
Contextobject as per #20, but ran into some issues. For some reason the context object seems to get inserted into the generated code. This is what I get:I don't fully understand what
gather,tag_locandtrans_blockare doing. Also I didn't find what the definition for the<|operator inside the_applypattern function is. I see how you are using theRecordpattern to do a kind of a destructuring bind on the keys of a dictionary, but I don't understand how the definition works from the MLStyle docs.