Skip to content

perf: avoid per-call ctx allocation in next_no_xml_space #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathieu17g wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: avoid per-call ctx allocation in next_no_xml_space #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/raw.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,12 @@ function next_no_xml_space(o::Raw) # same as v0.3.5
data = o.data
type = o.type
has_xml_space = o.has_xml_space
ctx = [false]
# `ctx` (the xml:space inheritance stack) is unused by this code path —
# `next_no_xml_space` is only called when the document has no `xml:space`
# attribute anywhere, so the per-node ctx is always `Bool[false]` and is
# never mutated. Reuse the parent's `ctx` instead of allocating a fresh
# one; on a 47 MiB file this drops ~60 MiB of cumulative allocation.
ctx = o.ctx
i = findnext(!xml_isspace, data, i)
if isnothing(i)
return nothing
Expand Down
Loading