Some tidying up#985
Open
penelopeysm wants to merge 14 commits into
Open
Conversation
Co-authored-by: SundaraRaman R <digital_carver@proton.me>
penelopeysm
commented
May 15, 2026
Member
Author
penelopeysm
left a comment
penelopeysm
left a comment
There was a problem hiding this comment.
I was thinking that we need to revert the major version bump first before making new fixes, since I'm not very keen on releasing a 3.x of JuliaFormatter. Once this is done, we can merge and release #983 as well :)
Member
Author
There was a problem hiding this comment.
@digital-carver I took this one from your PR, #984, if that's OK, I had to change it anyway and hopefully it'll make it easier to handle merge conflicts.
penelopeysm
commented
May 15, 2026
| @@ -0,0 +1,46 @@ | |||
| # This workflow tests that the pre-commit hook works as expected. | |||
Member
Author
There was a problem hiding this comment.
Since I reverted the jlfmt pre-commit hook, we only have the 'old' hook to test, i.e. the one that calls julia -e 'using JuliaFormatter' .... Once we add the jlfmt hook back, this will be useful for also testing its behaviour.
penelopeysm
commented
May 15, 2026
| - id: julia-formatter | ||
| name: "Julia Formatter" | ||
| entry: "jlfmt --inplace" | ||
| entry: "julia -e 'import JuliaFormatter: format; format(ARGS)'" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the v3.0 bump for a
jlfmtbased pre-commit workflow (it's probably easier to release this as a distinct pre-commit hook, that doesn't require a major version bump, which I think would be quite disruptive)Add a CI test for the pre-commit hook, to catch any regressions in behaviour.
Update links to point to new GitHub organisation. They currently redirect but this is not technically guaranteed
Remove HELP.md since there is help now (hopefully :))