-
Notifications
You must be signed in to change notification settings - Fork 261
Add autodocs for all libraries, take 2 [only docs] #2972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Superficially LGTM, but we sadly don't have preview functionality set-up. I take it you checked locally this looks OK? |
|
I didn't try to check this locally for lack of an NVIDIA GPU, should I? |
|
My intuition was that doctests would fail anyway if I tried to build locally |
|
Can anyone try building these docs locally? |
d0793f0 to
fd248dc
Compare
|
Trying now |
|
Doc build failed, I'll upload the log later |
|
Why did the ci get a green check 🤔? |
|
So apparently the docs build fails locally (according to @kshyatt) with this log I added the missing |
|
The other doctests worked this time on Buildkite, so maybe we're good to go! |
|
That probably means there are no docstrings in that library to begin with? I only set up autodocs so that if those docstrings exist, they will be displayed |

Replaces #2967