Skip to content

Conversation

@gdalle
Copy link

@gdalle gdalle commented Nov 14, 2025

Replaces #2967

@maleadt
Copy link
Member

maleadt commented Nov 14, 2025

Superficially LGTM, but we sadly don't have preview functionality set-up. I take it you checked locally this looks OK?

@gdalle
Copy link
Author

gdalle commented Nov 14, 2025

I didn't try to check this locally for lack of an NVIDIA GPU, should I?

@gdalle
Copy link
Author

gdalle commented Nov 14, 2025

My intuition was that doctests would fail anyway if I tried to build locally

@gdalle
Copy link
Author

gdalle commented Nov 19, 2025

Can anyone try building these docs locally?

@kshyatt
Copy link
Member

kshyatt commented Nov 19, 2025

Trying now

@kshyatt
Copy link
Member

kshyatt commented Nov 19, 2025

Doc build failed, I'll upload the log later

@gdalle
Copy link
Author

gdalle commented Nov 19, 2025

Why did the ci get a green check 🤔?

@gdalle
Copy link
Author

gdalle commented Dec 2, 2025

So apparently the docs build fails locally (according to @kshyatt) with this log
doclog.txt

I added the missing Adapt dep but the others seem to be failing doctests that I cannot fix locally for lack of an NVIDIA card. @maleadt who do you think could help out to get this merged?

@gdalle
Copy link
Author

gdalle commented Dec 8, 2025

The other doctests worked this time on Buildkite, so maybe we're good to go!

@kshyatt kshyatt requested a review from maleadt December 8, 2025 09:36
@maleadt maleadt self-assigned this Dec 8, 2025
@maleadt maleadt added the documentation Improvements or additions to documentation label Dec 8, 2025
@maleadt
Copy link
Member

maleadt commented Dec 8, 2025

Sections are empty:

image

@gdalle
Copy link
Author

gdalle commented Dec 8, 2025

That probably means there are no docstrings in that library to begin with? I only set up autodocs so that if those docstrings exist, they will be displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants