Add type-driven schema generation for 1.6#80
Merged
Conversation
Collaborator
|
I'm happy if you're happy |
Member
Author
|
Thanks. I've recently been adding "trim compile" test workloads to test suites, so wondering if I should try and do that for JSONSchema as well, but that can be a separate, follow up work. I'm also not sure my downstream packages relying on schema generation will even be trim-compile-able, so mabye not urgent anyway. |
Collaborator
|
I'd assume it's not trimmable because of this dispatch: JSONSchema.jl/src/validation.jl Lines 83 to 85 in 4076c12 Rather than some sort of enum-based type-stable but runtime lookup, I dispatch on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSONSchema.schema(::Type)generation while keepingschemaunexportedSchemanon-parametric and addJSONSchema.spec(schema), indexing helpers, and JSON serialization supportadditionalProperties, tuple variants, and draft 2020-12 tuple outputTesting
JULIA_PKG_PRECOMPILE_AUTO=0 julia --project=. -e 'using Pkg; Pkg.test()'LLMProviderstests against the pushed JSONSchema branchCo-authored by Codex