Wrap ExpandAtomicModifyPass (Julia 1.13)#564
Merged
Merged
Conversation
Julia 1.13 (JuliaLang/julia#57010, 1.13.0-DEV.321) added the ExpandAtomicModify function pass to lower the julia.atomicmodify pseudo-intrinsics; wrap it so downstream packages don't have to. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Noticed as part of EnzymeAD/Enzyme.jl#3178 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #564 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 47 47
Lines 3183 3183
=======================================
Hits 2748 2748
Misses 435 435
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia 1.13 (JuliaLang/julia#57010,
1.13.0-DEV.321) added theExpandAtomicModifyfunction pass, which lowers thejulia.atomicmodify.*pseudo-intrinsics. Wrap it so downstream packages (e.g. GPUCompiler.jl) don't need to define it themselves.The pass is registered in Julia as
FUNCTION_PASS("ExpandAtomicModify", ExpandAtomicModifyPass()); the version gate matches the introducing commit exactly (contrib/commit-name.sh aab74908dc6→1.13.0-DEV.321).Also adds it to the Julia-pipeline replication test in
test/newpm.jl, right afterFinalLowerGCPass, matching its placement in Julia'ssrc/pipeline.cpp.Tested on 1.13.0-rc1:
newpmandinteropsuites pass.🤖 Generated with Claude Code