refactor: standardize shell setup to improve non posix shell support#1487
Open
Wizzzzzzard wants to merge 22 commits intoJuliaLang:mainfrom
Open
Conversation
Wizzzzzzard
changed the title
Wizzzzzzard
force-pushed
the
refactor/standardize-shell-setup-to-improve-non-POSIX-support
branch
from
f73bcaf to
7702093
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was initially working on trying to add automatic integration for the fish shell (related to issue 594) but realised with the current setup it was very difficult to add non-POSIX compliant shells
This PR trys to simplify this process by adopting ideas from rustup's approach which uses templated shell scripts rather than inline shell code (e.g. for bash). It also tries to decouple the code relating to shell setup from the I/O and other concerns in
operations.rs.Hopefully the included changes can simplify the process of adding additional shells in the future.
@davidanthoff @KristofferC