change 1:ndims(X) to ntuple(identity, ndims(X))

[jishnub]

Fix #97

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (a25656d) to head (f3f1ead).
Report is 31 commits behind head on master.

Files with missing lines	Patch %	Lines
src/definitions.jl	83.33%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files           3        3           
  Lines         209      209           
=======================================
  Hits          182      182           
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jishnub]

Looks like FastTransforms and GenericFFT need updating

[devmotion]

Can we just use

Suggested change

	$f(x::AbstractArray) = $f(x, ntuple(identity, ndims(x)))
	$f(x::AbstractArray) = $f(x, Base.OneTo(ndims(x)))

? Maybe that already fixes constant propagation? It would be less breaking (I think) and should also be more efficient if ndims(x) is large.

[jishnub]

I don't think this necessarily fixes the issue without the compiler propagating ndims(x) as a constant.

Regarding large ndims, IIUC Tuples are performant till a length of 32, and it's uncommon to have arrays with that many dimensions. In any case, this could be an optimization for ndims(x)<4, which is perhaps the common case.

I fully understand and sympathize with your concern about breakages. I'll see if the direct dependants can be fixed first so that they accept arbitrary regions, before this is considered