Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 71.50% 73.51% +2.01%
==========================================
Files 5 5
Lines 544 540 -4
==========================================
+ Hits 389 397 +8
+ Misses 155 143 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm not sure this is strictly necessary for adding an extension: the extension would work only in Julia v1.9+, but can exist, without working also in previous releases. Requiring Julia v1.10 nowadays is a good idea regardless though. |
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
|
Same for #318. I could add v1.6 support to that, but it seems quite unnecessary to assume that would be useful at this point |
|
Seems fine to me at this point to require 1.10. |
| - 'mkl' | ||
| version: | ||
| - '1.6' | ||
| - 'min' |
There was a problem hiding this comment.
I didn't realize we could do this. So this automatically tests on the minimum-supported version from Project.toml?
| AbstractFFTs = "1.5" | ||
| FFTW_jll = "3.3.9" | ||
| LinearAlgebra = "<0.0.1, 1" | ||
| LinearAlgebra = "1" |
There was a problem hiding this comment.
Is https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958#update-november-9th-2023-2 still the recommended approach? Then this should be changed back to
| LinearAlgebra = "1" | |
| LinearAlgebra = "<0.0.1, 1" |
There was a problem hiding this comment.
That PSA says only to do that for packages that support < Julia v1.4, which this does not
There was a problem hiding this comment.
That's what the PSA said to do on 2nd November (https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958#update-november-2nd-2023-how-do-i-determine-what-the-compat-entry-should-be-for-a-stdlib-3) but in the latest update on 9th November (https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958#update-november-9th-2023-2) it seems to recommend this approach generally, without any specific lower or upper bounds on the Julia version.
devmotion
left a comment
There was a problem hiding this comment.
The PR probably should clean up a few unnecessary VERSION checks as well.
See #312 (comment) for explanation
The motivation for this change would be to allow adding extensions without adding unnecessary dependencies for users on pre-v1.10.
In particular, this makes it easier to finish #311
See also JuliaMath/AbstractFFTs.jl#140