SlurmManager: Add the custom_worker_flag option, but don't add it to the public API#74
Closed
DilumAluthge wants to merge 1 commit into
Closed
SlurmManager: Add the custom_worker_flag option, but don't add it to the public API#74DilumAluthge wants to merge 1 commit into
SlurmManager: Add the custom_worker_flag option, but don't add it to the public API#74DilumAluthge wants to merge 1 commit into
Conversation
SSHManager: Add the custom_worker_flag option, but don't add it to the public APISlurmManager: Add the custom_worker_flag option, but don't add it to the public API
0ebf6a6 to
a3027cc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 90.42% 87.03% -3.39%
==========================================
Files 2 2
Lines 94 108 +14
==========================================
+ Hits 85 94 +9
- Misses 9 14 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
09380f4 to
6cd6fae
Compare
Member
Author
|
This is not ready to merge yet, but I figure it can't hurt to get an early round of reviews. |
6cd6fae to
36469c6
Compare
…o the public API
36469c6 to
674f016
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have a use case where, instead of starting each remote worker with
julia --worker, I need to start the remote workers withjulia -e 'my_custom_code()'.This PR modifies
SlurmManagerto have acustom_worker_flagoption. Whencustom_worker_flagis specified, it will replace--worker. Whencustom_worker_flagis not specified (which is the default), it falls back to the current behavior.Example usage
This will start each remote worker with
julia -e 'my_custom_code()'.Public API vs private API
This PR does not add the new
custom_worker_flagoption to the public API. This allows us to change (or remove) it in the future.