Conversation
MilesCranmer
commented
Jun 29, 2023
src/units.jl
Outdated
| """ | ||
| function uparse(s::AbstractString) | ||
| return as_quantity(eval(Meta.parse(s)))::Quantity{DEFAULT_VALUE_TYPE,DEFAULT_DIM_TYPE} | ||
| function uparse(s::AbstractString)::Quantity{LazyFloat64,DEFAULT_DIM_TYPE} |
Member
Author
There was a problem hiding this comment.
This ensures that any unit is converted to a LazyFloat64 at the end. So even u"1.0" would become a LazyFloat64.
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
[Diff since v0.5.0](v0.5.0...v0.6.0) **Closed issues:** - Physical constants (#26) **Merged pull requests:** - Create (1) physical constants, and (2) symbolic dimensions object (#32) (@MilesCranmer)
Member
Author
|
Actually I think it's better if we only demote to abstract floats, but try to promote for everything else. Then we don't have to worry about integers. |
2 tasks
Member
Author
|
Moved to #66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates the
LazyFloat64type for storing units. It makes units try to demote their numeric type, rather than promote everything toFloat64:@mcabbott could you review this?