First pass at updating API for allowing animations#339
Conversation
|
I see that the Labeler is failing, is there a way I can address this? |
sglyon
left a comment
There was a problem hiding this comment.
Thank you for making an attempt at this! It will be a welcome and helpful contribution.
I have one question about the change to calling the javascript Plotly.newPlot function, but other than that this looks great.
| # Draw plot in container | ||
| Plotly.newPlot( | ||
| gd, $(lowered[:data]), $(lowered[:layout]), $(options) | ||
| gd, $(lowered), $(options) |
There was a problem hiding this comment.
Does this work as expected?
From the plotly.js docs (ref) it looks like we can use one of two forms of the newPlot function:
Plotly.newPlot(graphDiv, data, layout, config)
Plotly.newPlot(graphDiv, obj)Here I don't believe we are using either
|
I looked at the documentation, and I believe you caught a mistake. I have fixed the call in the most recent commit. |
|
Now that the PlotlyBase side has been merged, hopefully I'll be able to review this one soon. Thanks for the contributions and for the patience! |
|
Dr. Lyon,
Regards, |
Update display function to allow for frames for animation, and add animation example