Remove Blink dependency#451
Open
halleysfifthinc wants to merge 5 commits into
Open
Conversation
jd-foster
reviewed
Nov 3, 2023
|
|
||
| function Base.show(io::IO, mm::MIME"text/html", p::SyncPlot) | ||
| # if we are rendering docs -- short circuit and display html | ||
| if get_renderer() == DOCS |
Collaborator
There was a problem hiding this comment.
I think this function is used when generating the Documenter pages (not for Blink per se).
Collaborator
|
There could be an argument here for a weak dependency version too as in #463 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: This PR is not-entirely-serious, and is mostly intended to start a discussion.
Blink is a large dependency with a correspondingly large load time (
@time using Blink # 2.42 seconds on my PC).There are two major benefits from removing Blink as a dependency:
@time using PlotlyJSdrops from 3.12 to 1.02 seconds, with matching decreases in number of allocations and total allocated memory.Some relevant questions:
(Fixes #272)