Fix UUID case-sensitivity issue in registry lookup #484
Conversation
- Normalize registry package UUIDs to lowercase for matching - Fixes issue where packages with uppercase UUIDs in Registry.toml were incorrectly identified as not registered - Add test for registry with uppercase UUIDs - All 173 tests passing
There was a problem hiding this comment.
Pull request overview
This PR fixes a UUID case-sensitivity issue in registry lookup where packages with uppercase UUIDs in Registry.toml were incorrectly identified as not registered.
- Normalizes registry package UUIDs to lowercase for case-insensitive matching
- Adds comprehensive test coverage for the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tagbot/action/repo.py | Implements case-insensitive UUID matching by converting registry package keys to lowercase before lookup |
| test/action/test_repo.py | Adds test case verifying that uppercase UUIDs in the registry are properly matched with lowercase UUIDs from the project |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Seems reasonable but where's the problematic UUID? |
Looking at the actual issue #483: Plots.jl failed to match during registry lookup despite being registered. The fix ensures UUID comparison is case-insensitive by normalizing both the project UUID (line 273) and all registry package UUIDs (line 307) to lowercase before comparison. Even though the current registry snapshot may be entirely lowercase, the issue likely occurred because Plots.jl's Project.toml had a UUID with different casing than the registry keys, causing the case-sensitive dictionary lookup to fail silently. |
|
Yeah, I'm wondering where it was capitalized. That issue is recent. We should be able to figure it out. |
2 participants
This package is not registered, skippingwithPlots, no new tag #483