Non-monotone iterations in TRDH#108
Non-monotone iterations in TRDH#108geoffroyleconte wants to merge 9 commits intoJuliaSmoothOptimizers:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
- Coverage 63.39% 59.46% -3.94%
==========================================
Files 11 11
Lines 1295 1231 -64
==========================================
- Hits 821 732 -89
- Misses 474 499 +25 ☔ View full report in Codecov by Sentry. |
|
Here are the |
|
|
||
| Δobj = fk + hk - (fkn + hkn) + max(1, abs(fk + hk)) * 10 * eps() | ||
| fhmax = Mmonotone > 0 ? maximum(FHobj_hist) : fk + hk | ||
| Δobj = fhmax - (fkn + hkn) + max(1, abs(fhmax)) * 10 * eps() |
There was a problem hiding this comment.
I think the denominator of
There was a problem hiding this comment.
No, in fact, the denominator is ok, but that is a little bit by chance. I was on a wrong lead. The comment above is correct.
There was a problem hiding this comment.
Yes, that is probably why I could not prove the convergence and get decent results... I'll rebase with my branch linked the paper.
80dc0f5 to
043a0fc
Compare
The int parameter
Mmonotoneis used as a memory size. If it is 0, then this keeps the existing behaviour.