Skip to content

Address editor's comments#288

Merged
MohamedLaghdafHABIBOULLAH merged 3 commits intoJuliaSmoothOptimizers:paperfrom
MohamedLaghdafHABIBOULLAH:paper
Feb 5, 2026
Merged

Address editor's comments#288
MohamedLaghdafHABIBOULLAH merged 3 commits intoJuliaSmoothOptimizers:paperfrom
MohamedLaghdafHABIBOULLAH:paper

Conversation

@MohamedLaghdafHABIBOULLAH
Copy link
Collaborator

284

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses editorial comments from the JOSS review (issue #284), correcting typos and improving phrasing in the paper manuscript. The changes improve clarity and consistency throughout the document.

Changes:

  • Fixed terminology and grammar issues (e.g., "models around" instead of "models about", "In contrast to" instead of "In contrast with")
  • Improved sentence structure and clarity (rephrased allocation-free description, reorganized Regularized NLS Model sentence)
  • Added missing punctuation (comma after citation, Oxford comma in list)
  • Enhanced the conclusion with a forward-looking research pointer and added corresponding bibliography entry

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
paper/paper.md Addresses all editorial comments from JOSS review: corrects terminology, improves phrasing, adds missing punctuation, and enhances the conclusion with research context
paper/paper.bib Adds new bibliography entry for ongoing research on inexact proximal computations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@MaxenceGollier MaxenceGollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@MohamedLaghdafHABIBOULLAH MohamedLaghdafHABIBOULLAH merged commit 85f520a into JuliaSmoothOptimizers:paper Feb 5, 2026
2 checks passed
@fabian-s
Copy link

fabian-s commented Feb 5, 2026

great, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants