Address editor's comments#288
Merged
MohamedLaghdafHABIBOULLAH merged 3 commits intoJuliaSmoothOptimizers:paperfrom Feb 5, 2026
Merged
Address editor's comments#288MohamedLaghdafHABIBOULLAH merged 3 commits intoJuliaSmoothOptimizers:paperfrom
MohamedLaghdafHABIBOULLAH merged 3 commits intoJuliaSmoothOptimizers:paperfrom
Conversation
Copilot started reviewing on behalf of
MohamedLaghdafHABIBOULLAH
February 4, 2026 19:39
View session
ee28d76 to
4d57987
Compare
Copilot started reviewing on behalf of
MohamedLaghdafHABIBOULLAH
February 4, 2026 19:42
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses editorial comments from the JOSS review (issue #284), correcting typos and improving phrasing in the paper manuscript. The changes improve clarity and consistency throughout the document.
Changes:
- Fixed terminology and grammar issues (e.g., "models around" instead of "models about", "In contrast to" instead of "In contrast with")
- Improved sentence structure and clarity (rephrased allocation-free description, reorganized Regularized NLS Model sentence)
- Added missing punctuation (comma after citation, Oxford comma in list)
- Enhanced the conclusion with a forward-looking research pointer and added corresponding bibliography entry
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| paper/paper.md | Addresses all editorial comments from JOSS review: corrects terminology, improves phrasing, adds missing punctuation, and enhances the conclusion with research context |
| paper/paper.bib | Adds new bibliography entry for ongoing research on inexact proximal computations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
85f520a
into
JuliaSmoothOptimizers:paper
2 checks passed
|
great, thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
284