export profile data

[d-monnet]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Files	Coverage Δ
src/profiles.jl	100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

[tmigot]

Hi @d-monnet ! Thank you for the PR.

Connected to #140 (comment) do you think we would also need such function in BenchmarkProfiles.jl ?

Could you also think about some unit tests for this new functionality?

[d-monnet]

Hi @d-monnet ! Thank you for the PR.

Connected to #140 (comment) do you think we would also need such function in BenchmarkProfiles.jl ?

I'm not sure a .csv export function would be needed in BenchmarkProfiles.jl which is to me too low level for the generic user, but it would require almost zero work since it would be pretty much a copy of what's in get_profile_solvers_data and export_profile_solvers_data. Let me know if you want me to do that.

Could you also think about some unit tests for this new functionality?

Sure, I'll add the tests. Is it possible to create a file and load it through githut actions though ?

[tmigot]

Ok, so let's do it in BenchmarkProfiles.jl first then, if that's ok for you.

I see it is possible for the file. I could imagine the following process: call the function, test that the file exists, and remove the file.
Let me know if that doesn't work.

[d-monnet]

Here is the PR for csv export in BenchmarkProfiles.jl: JuliaSmoothOptimizers/BenchmarkProfiles.jl#95

[tmigot]

Hi @d-monnet , let me know when I can review this. Do you need a new release of BenchmarkProfiles.jl for this?

[d-monnet]

Hi @d-monnet , let me know when I can review this. Do you need a new release of BenchmarkProfiles.jl for this?

Sure, still working on it but it should be done (tests included ;) ) by the end of the week.
A new release of BenchmarkProfiles.jl would avoid code duplication in this package, if it's ok. However I think there is a compatibility issue for Tables versions between BenchmarkProfile.jl and SolverBenchmark.jl...

[tmigot]

There is a BenchmarkProfile.jl 0.4.4 with the new feature.
What is the compatibility issue?

[d-monnet]

There is a BenchmarkProfile.jl 0.4.4 with the new feature. What is the compatibility issue?

The new release of BenchmarkProfiles.jl requires Tables.jl 1.1 and PrettyTables.jl in SolverBenchmark.jl requires an older version.

[d-monnet]

Hi @tmigot, the PR is ready for review.

[tmigot]

Hi @d-monnet ! thank you for the PR (and sorry for the late review). It looks good overall, just some minor things about the documentation. We should also try to unify the punctuation on bullet list.
I will try to investigate why the tests are not passing for the documentation and julia 1.6.

[tmigot]

I think the failed doc is unrelated to this.
The CI Julia 1.6 failure, however is. It is probably because a file is not correctly removed ? The shortcut would be to modify https://github.com/JuliaSmoothOptimizers/SolverBenchmark.jl/blob/main/test/runtests.jl and tests pkgbmark.jl before the rest.

[tmigot]

Ok, so we will have to investigate further to see what is the problem with Julia 1.6... Otherwise it is good for me. Thank you!

[d-monnet]

Based on that branch I have developed a function to export the profile figures as tikz, which I prefer to include in my papers rather than the .png exported by performance_profile().
Let me know if/how you want me to add this contribution. Not sure how to do it properly until this PR is merged...

[tmigot]

Based on that branch I have developed a function to export the profile figures as tikz, which I prefer to include in my papers rather than the .png exported by performance_profile(). Let me know if/how you want me to add this contribution. Not sure how to do it properly until this PR is merged...

Would that involve additional packages?

[d-monnet]

Based on that branch I have developed a function to export the profile figures as tikz, which I prefer to include in my papers rather than the .png exported by performance_profile(). Let me know if/how you want me to add this contribution. Not sure how to do it properly until this PR is merged...

Would that involve additional packages?

No, the whole figure source code is "hand made" from profiles plots points.

[tmigot]

Ok, so why not. Maybe we do the same and add it to BenchmarkProfiles first ?

[d-monnet]

Ok, so why not. Maybe we do the same and add it to BenchmarkProfiles first ?

Here is the PR: JuliaSmoothOptimizers/BenchmarkProfiles.jl#104