Add tests with JET#955
Merged
Merged
Conversation
0f0ec5a to
546cddb
Compare
devmotion
commented
Apr 30, 2025
|
|
||
| ## scatter matrix | ||
|
|
||
| _unscaled_covzm(x::DenseMatrix, dims::Colon) = unscaled_covzm(x) |
Member
Author
There was a problem hiding this comment.
There exists no unscaled_covzm with this type signature in Statistics.
devmotion
commented
Apr 30, 2025
| _unscaled_covzm(x::DenseMatrix, dims::Colon) = unscaled_covzm(x) | ||
| _unscaled_covzm(x::DenseMatrix, dims::Integer) = unscaled_covzm(x, dims) | ||
|
|
||
| _unscaled_covzm(x::DenseMatrix, wv::AbstractWeights, dims::Colon) = |
devmotion
commented
Apr 30, 2025
| else | ||
| function (io::typeof(stderr))(obj::StatisticalModel) | ||
| Base.depwarn("stderr(obj::StatisticalModel) is deprecated, use stderror(obj) instead", :stderr) | ||
| io === stderr ? stderror(obj) : throw(MethodErrror(io, (obj,))) |
devmotion
commented
Apr 30, 2025
Comment on lines
-25
to
-26
| @deprecate scattermat_zm(x::DenseMatrix, dims::Int) scattermat_zm(x, dims=dims) | ||
| @deprecate scattermat_zm(x::DenseMatrix, wv::AbstractWeights, dims::Int) scattermat_zm(x::DenseMatrix, wv::AbstractWeights, dims=dims) |
Member
Author
There was a problem hiding this comment.
Also these do not exist.
devmotion
commented
Apr 30, 2025
andreasnoack
approved these changes
May 4, 2025
Member
|
JET makes tests fail due to version compat issues at #959. Any ideas what may be going on? |
Member
Author
|
It seems to be a bug in Pkg: #959 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on and opened against #954.
The most basic JET tests revealed a typo and few issues (calls of non-existing methods):
Edit: Tests currently fail on 1.12 (only somewhat experimental support for JET, an internal
AssertionErroris thrown) and on the other Julia versions since JET triggers method redefinitions (e.g. https://github.com/JuliaStats/StatsBase.jl/actions/runs/14743207189/job/41385529150?pr=955#step:6:178) that cause other subsequent tests to fail. See https://aviatesk.github.io/JET.jl/v0.9/jetanalysis/#jetanalysis-toplevel-entryEdit 2: "Fixed" by disabling JET tests on Julia 1.12 and moving the JET tests to the end, after all other tests.