Redact sensitive header values when displaying Headers collections#1328
Open
fredrikekre wants to merge 1 commit into
Open
Redact sensitive header values when displaying Headers collections#1328fredrikekre wants to merge 1 commit into
fredrikekre wants to merge 1 commit into
Conversation
Printing a Headers collection (REPL, at-show, logging, stacktraces) used the default AbstractVector show and leaked raw values of sensitive headers such as Authorization. Request/Response display already masks these via _HTTP_REDACTED_HEADERS; add Base.show methods for Headers that route values through the same _http_render_header_value redactor, restoring the HTTP.jl 1.x behavior of masking Authorization, Proxy-Authorization, Cookie, and Set-Cookie with "******". Redaction is display-only: header(), iteration, and indexing still return the real values, and wire output is unaffected. Co-Authored-By: Claude Code <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
- Coverage 88.08% 88.06% -0.02%
==========================================
Files 30 30
Lines 11847 11869 +22
==========================================
+ Hits 10435 10453 +18
- Misses 1412 1416 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Printing a Headers collection (REPL, at-show, logging, stacktraces) used
the default AbstractVector show and leaked raw values of sensitive
headers such as Authorization. Request/Response display already masks
these via _HTTP_REDACTED_HEADERS; add Base.show methods for Headers
that route values through the same _http_render_header_value redactor,
restoring the HTTP.jl 1.x behavior of masking Authorization,
Proxy-Authorization, Cookie, and Set-Cookie with "******".
Redaction is display-only: header(), iteration, and indexing still
return the real values, and wire output is unaffected.
Co-Authored-By: Claude Code noreply@anthropic.com