junos_acls: fix protocol handling for inet6 filters#815
Open
k-akashi wants to merge 1 commit intoJuniper:masterfrom
Open
junos_acls: fix protocol handling for inet6 filters#815k-akashi wants to merge 1 commit intoJuniper:masterfrom
k-akashi wants to merge 1 commit intoJuniper:masterfrom
Conversation
The junos_acls module always sets "protocol" in aces. For inet6 filters, Junos requires "next-header" instead of "protocol", and using "protocol" results in a configuration error. This change selects "protocol" for inet filters and "next-header" for inet6 filters based on the AFI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The junos_acls module always sets "protocol" in aces.
For inet6 filters, Junos requires "next-header" instead of "protocol", and using "protocol" results in a configuration error.
This change selects "protocol" for inet filters and "next-header" for inet6 filters based on the AFI.