feat: add learned partial mirror planner - #536
Conversation
|
Thanks — a learned mirror planner for dual-SSD is a sensible tool, and it's cleanly isolated (Python |
The only conflict was the handler dict in c/coli: this branch adds "mirror":cmd_mirror, dev added "tune":cmd_tune in JustVugg#673. Both are real commands with their own cmd_ function, so both entries are kept -- picking a side would have silently deleted a working subcommand. Verified: coli --help renders, and both 'coli mirror' and 'coli tune' resolve. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Merged — and since I told you the opposite ten days ago, you are owed the reasoning rather than just a state change. What I said then was:
The blocker there was my review time, not a defect in your work. I have now done that review, and it is the reason the verdict changed:
One resolution I made on your behalf, because I would rather you hear it from me than find it in the log. Your branch conflicted with The companion note still stands: when the dual-SSD path (#421) is something we are actively tuning, this is the tool that makes a partial mirror worth planning rather than guessing. It is in Thank you for the patience, and for shipping it with a test suite — that is most of why the review was quick once I actually sat down to it. |
dev went red on macOS only, in the test added by JustVugg#536: AssertionError: PosixPath('/private/var/folders/.../same.safetensors') != PosixPath('/var/folders/.../same.safetensors') On macOS /var is a symlink to /private/var, so tempfile hands back /var/folders/... while mirror_plan.py resolves every path it is given (discover_shards line 115, create_plan lines 197-199). The test compared a resolved path returned by the tool against an unresolved one it built itself. Linux has no such symlink, which is why it passed there -- including in my own pre-merge run, which is how this reached dev. Resolving the temp root in setUp makes every derived path resolved, so both sides match on every platform. Test-only; mirror_plan.py is unchanged. Verified by reproducing the macOS condition on Linux with a symlinked temp dir: the old comparison fails against it and the new one passes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Summary
.coli_usageWhy
Very large disk-streamed MoE models may span multiple volumes. Mirroring the empirically hottest complete shard/dependency set onto a faster or less contended volume can be tested safely without changing the authoritative model layout.
Validation
JustVugg/colibri:devrevisioncd278c227cf515b1f123c5fcc6bcf3c4820eafc9No model files were copied for the real-model validation; planning alone never activates a mirror.