Skip to content

Have created loader items inherit the parent context#12

Open
Znurre wants to merge 20 commits intoKDABLabs:masterfrom
Znurre:master
Open

Have created loader items inherit the parent context#12
Znurre wants to merge 20 commits intoKDABLabs:masterfrom
Znurre:master

Conversation

@Znurre
Copy link
Contributor

@Znurre Znurre commented Feb 18, 2018

The current behavior for LoaderWidget seems to differ from that of Loader in that components loaded by Loader will have access to the parent context's properties while items loaded by LoaderWidget will only have access to the root context's properties.
This change attempts to unify the behavior and have LoaderWidget behave the same way as Loader.

@0x6e
Copy link
Contributor

0x6e commented Feb 20, 2018

Hi Znurre,

thank you for your contributions. We'll take a look and get back to you by the end of the month.

Kind regards,
Nathan

@0x6e
Copy link
Contributor

0x6e commented Feb 27, 2018

Hi Znurre,

before we can accept your contributions to DeclarativeWidgets we will need a signed Copyright Assignment form from you, and if you are employed we will also need your employer to sign the Disclaimer part of the agreement. The form is attached to this comment, and includes instructions detailing what you need to do.

Kind regards,
Nathan

KDAB-CopyrightAssignmentForm.docx

@Znurre
Copy link
Contributor Author

Znurre commented Mar 20, 2018

Hi Nathan,

I've sent a signed Copyright Assignment form to the e-mail address specified in the form 8 days ago, but without any reply so far.

Best regards,
Lova

@0x6e
Copy link
Contributor

0x6e commented Mar 20, 2018

Hi Lova,

I'll chase it up, thanks for letting me know.

Kind regards,
Nathan

@0x6e
Copy link
Contributor

0x6e commented Mar 20, 2018

Hi Lova,

we haven't been able to find the e-mail you sent. Could you please resend it to nathan.collins@kdab.com

Kind regards,
Nathan

@0x6e 0x6e requested review from 0x6e and krake-kdab March 26, 2018 09:43
Copy link
Contributor

@0x6e 0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@bjorn
Copy link

bjorn commented Jul 5, 2021

Having support for Repeater would be so great, since we could then use a widgets-based view on a data model. Unfortunately, it appears this pull request got a little messy since unrelated commits were pushed to the source branch after the review was approved. Is there chance of still getting this merged?

@Znurre
Copy link
Contributor Author

Znurre commented Jul 5, 2021

I am not sure why I never got around to merging this. To be honest, I thought I did, but I guess not. If time permits, I will have a look at changing this PR to target another branch of my repo and prepare that for submission as per the scope of the original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants