Skip to content

Conversation

@rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Jul 3, 2025

Fixes an oversight in weights computation, where the number of currencies in a pool was not taken into account for the bonded-coins pallet's reset_team extrinsic.
Also updates the default weights accordingly.

Given that the run_benches_for_pallets.sh script no longer works, I've benchmarked this manually using the frame-omni-bencher. Double-check that I've done it right, given that it's my first time doing so.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner added the ci-skip-docs-pr ci-skip-docs-pr label Jul 3, 2025
@rflechtner rflechtner requested a review from Ad96el July 3, 2025 12:23
Copy link
Contributor

@Ad96el Ad96el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm curious why this wasn't catchedduring the release. The node should not compile after running the benchmarks, no?

@rflechtner
Copy link
Contributor Author

LGTM. I'm curious why this wasn't catched during the release. The node should not compile after running the benchmarks, no?

Yes indeed, but the benchmarks weren't actually run, that's why this wasn't caught.

@rflechtner rflechtner merged commit af0e51c into develop Jul 16, 2025
28 of 34 checks passed
@rflechtner rflechtner deleted the rf-fix-bonded-coins-bench branch July 16, 2025 07:57
rflechtner added a commit that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-skip-docs-pr ci-skip-docs-pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants