fix: allow fast unstaking for all #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflechtner
requested review from
Ad96el and
ntn-x2
and removed request for
Ad96el
abdulmth
reviewed
Jul 7, 2025
| pub const STAKE_DURATION: BlockNumber = 1; | ||
|
|
||
| #[cfg(feature = "fast-gov")] | ||
| pub const MIN_COLLATORS: u32 = 4; |
Contributor
There was a problem hiding this comment.
Don't we want to change this too?
Contributor
There was a problem hiding this comment.
I don't think this constant is very important. It's only used in set_max_selected_candidates as a validation parameter.
The pallet isn't used to fetch collators anyway
Contributor
Author
There was a problem hiding this comment.
Yes, this constraints the setting determining how many candidates are selected as collators. Which has become irrelevant now, and I would want to avoid fiddling with settings where not required, given that the pallet is pretty complex and it's hard to foresee all consequences of such changes.
Ad96el
reviewed
Jul 15, 2025
rflechtner
added a commit
that referenced
this pull request
Jul 16, 2025
Allows unstaking for all collator candidates and delegators in the staking pallet with minimum delay. Also prevents additional candidates or delegators from joining, and existing ones from increasing their stake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows unstaking for all collator candidates and delegators in the staking pallet with minimum delay.
Also prevents additional candidates or delegators from joining, and existing ones from increasing their stake.
Note that collator selection is no longer dependent on the staking pallet, so removal of all candidates is inconsequential for the collator set.
Checklist:
array[3]useget(3), ...)