Closed
Conversation
…rt time Move the module-level `from .traceback import Traceback` to a lazy import inside `emit()`, guarded by the `rich_tracebacks` check. This avoids loading the traceback -> syntax -> pygments chain (~20ms) when RichHandler is used without rich tracebacks enabled (the default). The Traceback type annotation in `render()` is changed to a string literal for forward-reference compatibility.
Run `python benchmarks/bench_import.py` to measure RichHandler import time and see the Console-to-RichHandler gap that this PR reduces.
Replace two separate hyperfine invocations with a single parameterized run using -L branch. This produces a proper relative comparison with statistical significance in one invocation. Also adds a Console baseline measurement to show the optimization only affects the traceback import chain, not the common path.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from .traceback import Tracebackfrom module-level to insideemit(), only whenrich_tracebacksis enabledBenchmarks (Standard_D2s_v5, Python 3.13, hyperfine)
RichHandlerThe gap between
ConsoleandRichHandler(which isolates the Traceback import cost) collapsed from ~22ms to ~3ms.Reproduce locally
The
--compareflag uses hyperfine's native--parameter-listto measure both branches in a single invocation, producing a statistically rigorous relative comparison:Checks