perf: replace pathlib with os.path.basename in logging.py#8
Closed
perf: replace pathlib with os.path.basename in logging.py#8
Conversation
Replace `from pathlib import Path` + `Path(x).name` with `os.path.basename(x)`. os is already imported transitively and available at near-zero cost, while pathlib adds ~4-5ms to the RichHandler import path. This is also a minor runtime improvement: os.path.basename is a simple string operation vs Path object construction + attribute access.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
from pathlib import Path+Path(x).namewithos.path.basename(x)inRichHandler.render().osis already imported transitively and available at near-zero cost, whilepathlibadds ~4-5ms to the RichHandler import path.This is also a minor runtime improvement:
os.path.basenameis a simple string operation vsPathobject construction + attribute access.Testing
952 passed on CPython 3.9–3.14 and PyPy 3.10.