Patch GameDatabase.ExistsModel similarly to other methods#353
Open
Phantomical wants to merge 1 commit intoKSPModdingLibs:devfrom
Open
Patch GameDatabase.ExistsModel similarly to other methods#353Phantomical wants to merge 1 commit intoKSPModdingLibs:devfrom
Phantomical wants to merge 1 commit intoKSPModdingLibs:devfrom
Conversation
This one method call takes up ~80% of ModuleWaterfallFX.Start, which can account for a pretty significant amount of time during scene switches. This is especially true on more heavily modded games where the list of models can be much larger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one method call takes up ~80% of ModuleWaterfallFX.Start, which can account for a pretty significant amount of time during scene switches. This is especially true on more heavily modded games where the list of models can be much larger. The added patch is basically trivial since all the hard parts have been implemented already.
For some numbers, here's a break down of how long it takes for
ModuleWaterfallFXon one of my test saves