Update 00002-medium-return-type.ts

[eljily]

No description provided.

[eljily]

@eljily ShameOnU is reviewing your code...

[eljily]

@eljily Let's take a closer look at the changes made in the code snippet you provided. It seems there are a few issues that need addressing to enhance best practices and reduce technical debt.

Issues Identified:

1. Typo in Type Assertion:

   • The line Expect<Equaal<ComplexObject, MyReturnType<() => ComplexObject>>> contains a typo: Equaal should be corrected to Equal.

2. Inconsistent Function Logic:

   • The function fn has been modified from returning 1 or 2 based on the boolean condition to always returning 1. This change seems illogical unless there's a specific reason for it. If the intention was to keep the original logic, it should be reverted back to v ? 1 : 2.

3. Redundant Type Assertions:

   • The line Expect<Equal<1 | 2, MyReturnType<typeof fn1>>> appears twice. This redundancy should be removed to keep the code clean and maintainable.

4. Type Safety:

   • The parameter w in fn1 is typed as any. This can lead to potential issues down the line. It would be better to specify a more precise type or use generics if the type is not known.

Suggested Code Improvements:

Here’s a revised version of the code with the above issues addressed:

import type { Equal, Expect } from './test-utils'

type cases = [
  Expect<Equal<string, MyReturnType<() => string>>>,
  Expect<Equal<123, MyReturnType<() => 123>>>,
  Expect<Equal<ComplexObject, MyReturnType<() => ComplexObject>>>, // Fixed typo
  Expect<Equal<Promise<boolean>, MyReturnType<() => Promise<boolean>>>>,
  Expect<Equal<() => 'foo', MyReturnType<() => () => 'foo'>>>,
  Expect<Equal<1 | 2, MyReturnType<typeof fn1>>>, // Removed redundancy
]

type ComplexObject = {
  prev(): number
}

const fn = (v: boolean) => v ? 1 : 2; // Reverted to original logic
const fn1 = (v: boolean, w: unknown) => v ? 1 : 2; // Changed 'any' to 'unknown' for better type safety

// ============= Your Code Here =============

Summary of Changes:

• Corrected the typo in the type assertion.
• Reverted the logic of fn to its original form.
• Removed the duplicate assertion for fn1.
• Changed the type of w in fn1 from any to unknown for better type safety.

By implementing these changes, the code will be cleaner, more maintainable, and adhere to better TypeScript practices. Remember, a little attention to detail goes a long way in reducing technical debt!