Skip to content

Conversation

@KolbyML
Copy link

@KolbyML KolbyML commented Jan 9, 2026

This will be helpful to know if PR's are any good or not

@KolbyML KolbyML marked this pull request as draft January 9, 2026 07:47
@KolbyML KolbyML changed the title Add Release Workflow to reduce maintainers burden Add Build Workflow to make sure PR's at least compile Jan 9, 2026
@KolbyML KolbyML force-pushed the add-publish-workflow branch from ca495a5 to 5eb3a69 Compare January 9, 2026 07:49
@KolbyML KolbyML force-pushed the add-publish-workflow branch from 5eb3a69 to 84eb524 Compare January 9, 2026 07:50
@KolbyML KolbyML marked this pull request as ready for review January 9, 2026 07:51
Copy link
Owner

@KamWithK KamWithK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few quick questions

uses: actions/checkout@v4

- name: Set up JDK 17
uses: actions/setup-java@v4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using v4? I think there is a newer version?


steps:
- name: Checkout Code
uses: actions/checkout@v4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using v4? I think there is a newer version?

- name: Grant Execute Permission for Gradlew
run: chmod +x gradlew

- name: Run Build and Unit Tests
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does gradlew build actually run unit tests?
FYI the only two tests in this repo are just examples not real tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants