-
Notifications
You must be signed in to change notification settings - Fork 38
Add Build Workflow to make sure PR's at least compile #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ca495a5 to
5eb3a69
Compare
5eb3a69 to
84eb524
Compare
KamWithK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few quick questions
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using v4? I think there is a newer version?
|
|
||
| steps: | ||
| - name: Checkout Code | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using v4? I think there is a newer version?
| - name: Grant Execute Permission for Gradlew | ||
| run: chmod +x gradlew | ||
|
|
||
| - name: Run Build and Unit Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does gradlew build actually run unit tests?
FYI the only two tests in this repo are just examples not real tests
This will be helpful to know if PR's are any good or not