To process a list of files listing all files with theabsolute path.#146
Open
monodera wants to merge 1 commit intoKeck-DataReductionPipelines:devfrom
Open
To process a list of files listing all files with theabsolute path.#146monodera wants to merge 1 commit intoKeck-DataReductionPipelines:devfrom
monodera wants to merge 1 commit intoKeck-DataReductionPipelines:devfrom
Conversation
Contributor
|
Thanks @monodera ! I've pointed the PR to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the files of, e.g.,
Flat.txtandFlatThermal.txt, are listed as the absolute paths, the currentlist_file_to_stringsinIO.pyignores the first file. The pull request take care such cases.I tried with the following files:
With the current release, the log file looks like the following.
You can see the first file is not loaded.
WIth the modification, the log looks like the following.
Here the first file in the lists are correctly read.
(sorry that my editor automatically did some formatting....)