Draft
Conversation
Contributor
|
I checked out this branch to experiment with the changes, but the existing tooling doesn't work with it; I'm hoping the required additional changes are minimal, because this pull request is already extensive, but I think we're going to need those changes to see how this proposed structure changes how the core functionality gets used. Importing the module presently doesn't work, so none of the existing tools work, throwing this exception: I imagine there will be others once that's resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #19
The current implementation couples protocol semantics to the ZeroMQ transport layer. This makes it difficult to reason about the protocol independently of its transport. As the system evolves, this coupling increases maintenance overhead and limits extensibility.
The refactor introduces a layered structure where:
Protocol layer
Transport layer
By isolating protocol semantics, the messaging model becomes easier to understand, implement, and reuse across different languages and communication backends. This lays the foundation for supporting multiple transport types while reducing coupling between message structure and delivery mechanism.
init.pyhas additional design notes for reference.Protocol Architectural Direction
Added Protocol abstraction for user-facing messaging operations
Supports:
This centralizes orchestration logic previously spread across transport code.
With this change, follow-up work will migrate the existing mKTL implementation to use the separated protocol and transport layers. This transition will be performed incrementally to preserve current functionality while improving modularity and extensibility.