Skip to content

feat: add kh w feedback thin wrapper#65

Merged
eskp merged 1 commit intomainfrom
feat/wallet-feedback
May 7, 2026
Merged

feat: add kh w feedback thin wrapper#65
eskp merged 1 commit intomainfrom
feat/wallet-feedback

Conversation

@eskp
Copy link
Copy Markdown
Contributor

@eskp eskp commented May 7, 2026

Summary

  • Mirrors the new `feedback` subcommand in @keeperhub/wallet so users can submit ERC-8004 ReputationRegistry feedback for a workflow execution they paid for without dropping out of the `kh` CLI shell.
  • Closes the user-facing loop alongside the keeperhub backend (PR #1160 merged) and the agentic-wallet npm change. Validated end-to-end on Ethereum mainnet against KeeperHub's ERC-8004 agent (id 31875): tx `0xd8391d...3e92` confirmed in block 25041073.

Usage

```bash

5-star rating for an execution this wallet paid for

kh w feedback --execution-id c5ybokpmwxi7kiau5wxja --value 5

4.5-star rating with a comment

kh w feedback --execution-id c5ybokpmwxi7kiau5wxja --value 45 --decimals 1 \
--comment "very helpful"

Rate a different agent

kh w feedback --execution-id --value 5 --agent-id 12345
```

Test plan

  • `go build ./...` clean
  • `go test ./cmd/wallet/...` clean (existing wallet test suite passes)
  • Pin to the agentic-wallet release that ships the upstream `feedback` subcommand once published (release-please will minor-bump from chore(deps): bump actions/checkout from 4 to 6 #32)

Notes

Same wrapper pattern as `kh w add` / `info` / `fund` / `link`: forwards to `npx @keeperhub/wallet feedback ` via stdlib `os/exec`. The flag layer here is dumb pass-through -- no payload parsing happens in Go because the npm package is the canonical signing layer. If the upstream subcommand grows new flags, only the dumb forwarding here needs an update.

Mirrors the new `feedback` subcommand in @keeperhub/wallet so users
can submit ERC-8004 ReputationRegistry feedback for a workflow
execution they paid for without dropping out of the kh CLI shell.

Same wrapper pattern as `kh w add` / `info` / `fund` / `link`: forwards
to `npx @keeperhub/wallet feedback <flags>` via os/exec. No payload
parsing happens here -- the npm package is the canonical signing layer.

Validated end-to-end on Ethereum mainnet against KeeperHub's
ERC-8004 agent (id 31875): tx 0xd8391d...3e92 confirmed in block
25041073.
@eskp eskp merged commit 79be12c into main May 7, 2026
4 checks passed
@eskp eskp deleted the feat/wallet-feedback branch May 7, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant