Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for document-related ASN.1 types in the keetanetwork-asn1 codebase, introducing new data structures for identity documents (passport, driver's license, ID cards, etc.) along with supporting types for references, digests, and person identification. The changes include significant refactoring of the build script to better handle extension types and improve code maintainability.
Key Changes:
- Added new Document ASN.1 type with 7 document subtypes (driver's license, passport, ID card, visa, etc.) to support identity verification workflows
- Introduced supporting types (Reference, DigestInfo, ExternalReference) for handling external document references with encryption and digest information
- Refactored build.rs Default implementation generation into reusable helper functions with improved enum type detection
- Made breaking API changes to EntityType (CHOICE → SEQUENCE) and PersonIdentificationSchemeNameChoice (UTF8String → ENUMERATED)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| keetanetwork-asn1/oids.json | Added Document type with 21 fields and 7 document subtypes; added name components (firstName, lastName, middleName), nationality, and PersonIdentificationSchemeNameProprietary enum; changed EntityType from CHOICE to SEQUENCE; reformatted for readability |
| keetanetwork-asn1/build.rs | Added generate_extension_types() function for processing extension types with dependency sorting; refactored Default implementation generation into helper functions (get_ordered_field_names, collect_enumerated_types, generate_field_defaults); added rustfmt call to format generated code |
| keetanetwork-asn1/asn1/iso20022.asn | Added ASN.1 definitions for DigestInfo, ExternalReference, Reference, Document, and moved EntityType definition; added FirstName, LastName, MiddleName, Nationality primitives; added PersonIdentificationSchemeNameProprietary enumeration |
| Makefile | Replaced emoji characters with plain text prefixes (ERROR, WARNING, PASS, FAIL) for better terminal compatibility; adjusted indentation for alignment |
| keetanetwork-x509/src/utils.rs | Changed test vector from vec![] to array literal [] for minor performance improvement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Srayman
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports updates ASN.1 types.