Draft
Conversation
Collaborator
Author
|
I will look at the test failures tomorrow. |
Member
|
It's not clear what the point of this change is. |
Collaborator
Author
|
I think the reference I attached causes confusion in the description. Let me get back to this PR when I add support for secp256k1/secp256r1 in ledger device app, as it will add more context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signature verification now rejects high-S signatures (BIP-62). Added normalize_low_s() and is_low_s() utility functions for both secp256k1 and secp256r1.
Verifiers will reject any ECDSA signature where s > n/2. This prevents signature malleability attacks since both (r, s) and (r, n - s) are mathematically valid for the same message.
If you have an existing high-S signature, call normalize_low_s() to convert it before verification.
Reference: BIP-62: Dealing with malleability