Implement keetanetwork-block crate with block and operation types by mamonet · Pull Request #3 · KeetaNetwork/node-rs

mamonet · 2026-01-10T19:34:53Z

This PR adds the following features:

Shared keetanetwork-block crate for block and operation types
Zero-copy types with lifetime parameters for no_std environments
Includes all 11 operation types matching the protocol spec
Add address validation based on algorithm prefix (secp256k1/Ed25519/secp256r1) [REMOVED - Duplicate with account code]

TODO

Vote types (X.509 certificate-based)
VoteStaple types
MultiSigSignerInfo (nested multisig)

keetanetwork-block/src/types.rs

rkeene · 2026-01-10T19:49:32Z

keetanetwork-block/src/types.rs

+    /// Ed25519: 32-byte pubkey
+    pub const ED25519: u8 = 0x01;
+    /// secp256r1 (NIST P-256): 33-byte compressed pubkey
+    pub const SECP256R1: u8 = 0x02;


Suggested change

pub const SECP256R1: u8 = 0x02;

pub const SECP256R1: u8 = 0x06;

rkeene · 2026-01-10T19:51:27Z

keetanetwork-block/src/types.rs

+    /// Destination account
+    pub to: &'a [u8],
+    /// Amount to send
+    pub amount: u64,


The amount may exceed u64's range and a bigint type is really required

Same is true of all below

This types are shared with a Ledger device app (no_std, no alloc). I'm already using &'a [u8] for addresses, tokens, and other fields to reference the raw DER bytes directly (zero-copy). The same approach works for integers, &'a [u8] stores the big-endian DER integer bytes, representing arbitrary-precision values without allocation.

He is referring to amount which will overflow.

Would https://github.com/RustCrypto/crypto-bigint work? PS, this is re-exported in keetanetwork-crypto.

From docs.keeta.com/components/ledger: "balances are maintained on a per-token basis on each account and are maintained as an arbitrary large big integer." but in other 3rd-party websites like https://coingecko.com/learn/what-is-keeta-network I can see "KTA is the native token of the Keeta Network and the backbone of its economy. It has a fixed maximum supply of 1 billion tokens" in this case we can safely use crypto-bigint U128

That only refers to that native KTA token, other tokens exist on the network.

In this case, we will get back to the reference approach since all crypto-bigint types are limited.

Copilot

Pull request overview

This PR introduces a new keetanetwork-block crate that provides foundational block and operation type definitions for the Keeta blockchain. The implementation emphasizes zero-copy design with lifetime parameters to support no_std environments while maintaining flexibility through optional alloc and std features.

Changes:

Added shared type definitions for blocks (V1 and V2) and all 11 blockchain operations
Implemented address validation based on algorithm prefix (secp256k1, Ed25519, secp256r1)
Configured feature flags to support no_std, alloc, and std environments

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
keetanetwork-block/Cargo.toml	Defines feature flags for std/alloc/no_std support and removes unused dependencies
keetanetwork-block/src/lib.rs	Exports public API with conditional compilation for alloc-dependent types
keetanetwork-block/src/types.rs	Implements all block types, operation structures, and address validation logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

keetanetwork-block/src/types.rs

mamonet · 2026-01-11T07:56:44Z

@rkeene do you suggest to put the remaining types here or in different PR?

sephynox · 2026-01-12T19:11:42Z

keetanetwork-block/src/types.rs

+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum AdjustMethod {
+	Add,
+	Remove,


The TS uses Subtract not Remove. We should probably keep the naming consistent.

ASN.1 uses Remove instead of Subtract, I was confused by this one too.

should I change it for AdjustMethodRelative too?

Yes, naming should be the same

sephynox · 2026-01-12T19:20:24Z

keetanetwork-block/src/types.rs

+pub struct BlockHeader<'a> {
+	/// Network ID
+	pub network: u64,
+	/// Subnet ID (optional)
+	pub subnet: Option<u64>,
+	/// Idempotent key for deduplication (optional)
+	pub idempotent: Option<&'a [u8]>,
+	/// Date as GeneralizedTime raw bytes
+	pub date: &'a [u8],
+	/// Block purpose (V2 only, defaults to Generic for V1)
+	pub purpose: BlockPurpose,
+	/// Account public key with type prefix
+	pub account: &'a [u8],
+	/// Signer public key with type prefix (may be same as account)
+	pub signer: &'a [u8],
+	/// Previous block hash (32 bytes)
+	pub previous: &'a [u8],
+}


The signatures are currently missing. Is this going to be added later?

I will add signatures next

sephynox · 2026-01-12T19:23:52Z

keetanetwork-block/src/types.rs

+/// [5] TOKEN_ADMIN_SUPPLY operation - Modify token supply
+#[derive(Debug, Clone, Copy)]
+pub struct TokenAdminSupplyOp<'a> {
+	/// Amount to modify
+	pub amount: &'a [u8],
+	/// Method (add/remove/set)
+	pub method: AdjustMethod,
+}
+
+/// [6] TOKEN_MODIFY_BALANCE operation - Modify account token balance
+#[derive(Debug, Clone)]
+pub struct TokenModifyBalanceOp<'a> {
+	/// Token to modify balance of
+	pub token: &'a [u8],
+	/// Amount to modify
+	pub amount: &'a [u8],
+	/// Method (add/remove/set)
+	pub method: AdjustMethod,
+}
+


You used TOKEN_ADMIN_SUPPLY but not TOKEN_ADMIN_MODIFY_BALANCE. We could probably make it consistent.

rkeene · 2026-01-12T20:09:04Z

@rkeene do you suggest to put the remaining types here or in different PR?

I think it's fine to include that change in this PR since it's a dependency -- otherwise you would need to re-org and re-base but without much gained from it here.

ezraripps · 2026-01-12T21:55:46Z

keetanetwork-block/src/types.rs

+impl From<u8> for AdjustMethodRelative {
+	fn from(value: u8) -> Self {
+		match value {
+			0 => AdjustMethodRelative::Add,
+			1 => AdjustMethodRelative::Remove,
+			n => AdjustMethodRelative::Unknown(n),
+		}
+	}
+}


This should reject/throw since its invalid otherwise

It cannot so it will need to be a TryFrom instead.

I used TryFrom instead

keetanetwork-block/src/types.rs

sephynox · 2026-01-13T00:13:14Z

keetanetwork-block/src/types.rs

+#[derive(Debug, Clone)]
+pub enum Operation<'a> {
+	/// [0] Send tokens
+	Send(SendOp<'a>),
+	/// [1] Set representative
+	SetRep(SetRepOp<'a>),
+	/// [2] Set account info
+	SetInfo(SetInfoOp<'a>),
+	/// [3] Modify permissions
+	ModifyPermissions(ModifyPermissionsOp<'a>),
+	/// [4] Create identifier (token, multisig, swap)
+	CreateIdentifier(CreateIdentifierOp<'a>),
+	/// [5] Token admin supply
+	TokenAdminSupply(TokenAdminSupplyOp<'a>),
+	/// [6] Token modify balance
+	TokenModifyBalance(TokenModifyBalanceOp<'a>),
+	/// [7] Receive tokens
+	Receive(ReceiveOp<'a>),
+	/// [8] Manage certificate
+	ManageCertificate(ManageCertificateOp<'a>),
+	/// [9] Match swap
+	MatchSwap(MatchSwapOp<'a>),
+	/// [10] Cancel swap
+	CancelSwap(CancelSwapOp<'a>),
+	/// Unknown operation type
+	Unknown(u32),


The operation IDs would need to be explicitly defined with implemented DER.

Moreover, I don't know if this would work as expected. We would need explicit context tagging.

I plan to address that by adding #[derive(Choice)] with #[asn1(context_specific = "N")] attributes - the der crate handles explicit tagging automatically

sephynox · 2026-01-13T00:18:40Z

keetanetwork-block/src/types.rs

+pub enum AdjustMethodRelative {
+	Add,
+	Remove,
+	Unknown(u8),
+}


I am not sure this is a good approach. We should just return Result instead when using an unsupported AdjustMethod.

sephynox · 2026-01-13T00:18:57Z

keetanetwork-block/src/types.rs

+			0 => AdjustMethod::Add,
+			1 => AdjustMethod::Remove,
+			2 => AdjustMethod::Set,
+			n => AdjustMethod::Unknown(n),


We should return Result not use Unknown.

sephynox · 2026-01-13T00:21:25Z

keetanetwork-block/src/types.rs

+	pub fn new(header: BlockHeader<'a>, operations: Vec<Operation<'a>>) -> Self {
+		Self { version: BlockVersion::V1, header, operations }
+	}
+
+	/// Create a new V2 block
+	pub fn new_v2(header: BlockHeader<'a>, operations: Vec<Operation<'a>>) -> Self {
+		Self { version: BlockVersion::V2, header, operations }
+	}


We may want a KeetaBlockBuilder instead of new_v*

let block = KeetaBlockBuilder::from(BlockVersion::V*) .with_block_header(header) .with_operations(operations) .build();

Something like so.

I added KeetaBlockBuilder but I set header in constructor since it's not optional for both versions

sephynox · 2026-01-13T00:21:54Z

keetanetwork-block/src/types.rs

+pub enum BlockPurpose {
+	Generic,
+	Fee,
+	Unknown(u8),


There should be no Unknowns.

sephynox · 2026-01-13T00:28:35Z

keetanetwork-block/src/types.rs

+/// Expected key sizes (prefix + pubkey)
+const SECP256K1_KEY_SIZE: usize = 34; // 1 + 33
+const ED25519_KEY_SIZE: usize = 33;   // 1 + 32
+const SECP256R1_KEY_SIZE: usize = 34; // 1 + 33


These things should probably be in keetanetwork-crypto if they are not already.

We can feature gate minimal items like constants and utils

sephynox · 2026-01-13T00:29:25Z

keetanetwork-block/src/types.rs

+pub fn is_valid_address(addr: &[u8]) -> bool {
+    if addr.is_empty() {
+        return false;
+    }
+    match addr[0] {
+        algo_prefix::SECP256K1 => addr.len() == SECP256K1_KEY_SIZE,
+        algo_prefix::ED25519 => addr.len() == ED25519_KEY_SIZE,
+        algo_prefix::SECP256R1 => addr.len() == SECP256R1_KEY_SIZE,
+        _ => false, // Unknown algorithm prefix
+    }
+}


This should also probably be in keetanetwork-accounts.

We can feature gate minimal items like constants and utils.

ezraripps · 2026-01-14T18:31:46Z

keetanetwork-block/src/types.rs

+#[derive(Debug, Clone)]
+pub struct CancelSwapOp<'a> {
+	/// Swap account to cancel
+	pub swap: &'a [u8],


Should this be a reference to an account instead?

Using &[u8] for accounts/addresses is intentional, this is a zero-copy design for Ledger (no alloc). The field name and doc comment convey the semantic type.

mamonet · 2026-01-19T10:28:57Z

I think the changes covers the keetanetwork-block work we scoped.

Summary of implementation:

DER encoding/decoding: support for all types (V1/V2 blocks, operations, signatures) with support for no_alloc environments
Multisig support: Added signer types in addition to vote & certificate types
JS SDK compatibility: Roundtrip tests verify byte-exact encoding against real mainnet blocks and manually constructed test vectors

Unrelated Changes

Fixed clippy useless_vec warning in keetanetwork-x509/src/utils.rs (replaced vec![] with array literal in test)

All tests passing. Ready for review.

keetanetwork-block/src/types.rs

rkeene · 2026-01-21T19:15:11Z

keetanetwork-block/src/types.rs

+#[derive(Debug, Clone, Copy, Sequence)]
+pub struct TokenRate<'a> {
+	/// Token public key
+	pub token: Bytes<'a>,


Why do we use undifferentiated Bytes here instead of something higher-level and more specific (account) ?

This layer mirrors the ASN.1 (all OCTET STRING); semantic validation happens upstream in TS via assertKeyType()
can add aliases for clarity: pub type TokenId<'a> = Bytes<'a>; No compile-time safety, but documents intent. Prefer newtype wrappers instead?

@sephynox @mamonet It still seems like it should be a type with an assertKeyType() method rather than undifferentiated bytes

keetanetwork-block/src/types.rs

rkeene · 2026-01-21T19:22:00Z

keetanetwork-block/src/types.rs

+	pub signature: &'a [u8],
+}
+
+/// Vote staple - bundles blocks with their votes


Vote Staples make few other guarantees as well:

All votes have the same set of block hashes in the same order

All blocks are referenced by the votes

All blocks referenced in the votes are present

All votes are of the same level of permanence (temporary or permanent)

Interesting design for packaging - I'm familiar with OCSP stapling, which bundles certificate status proofs so verifiers don't need extra roundtrips, similar concept here with votes and blocks.
These invariants make sense for that model, want me to add them as doc comments on VoteStaple, implement a validate() method or both?

Either is fine at this point, but the validation is important to do at some point because it's not a valid vote staple unless those conditions are met

sonarqubecloud · 2026-02-05T16:51:26Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.2% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

Add Keeta block and operation types for DER parsing

cef22d4

rkeene reviewed Jan 10, 2026

View reviewed changes

ezraripps requested a review from Copilot January 10, 2026 20:07

Copilot started reviewing on behalf of ezraripps January 10, 2026 20:08 View session

Copilot AI reviewed Jan 10, 2026

View reviewed changes

keetanetwork-block/src/types.rs Outdated Show resolved Hide resolved

keetanetwork-block/src/types.rs Outdated Show resolved Hide resolved

keetanetwork-block/src/types.rs Show resolved Hide resolved

keetanetwork-block/src/types.rs Show resolved Hide resolved

mamonet added 4 commits January 10, 2026 23:19

Store DER integers as &'a [u8]

788a2a4

Remove address validation exports from public API

c7e1ce0

Remove #[repr(u8)] from enums in types.rs

147ab9c

Fix formatting for block crate

a17c01b

sephynox assigned mamonet Jan 12, 2026

sephynox self-requested a review January 12, 2026 18:59

sephynox added the enhancement New feature or request label Jan 12, 2026

mamonet mentioned this pull request Jan 12, 2026

Using rasn for Keeta block types #4

Open

sephynox reviewed Jan 12, 2026

View reviewed changes

ezraripps reviewed Jan 12, 2026

View reviewed changes

keetanetwork-block/src/types.rs Outdated Show resolved Hide resolved

sephynox reviewed Jan 13, 2026

View reviewed changes

mamonet added 3 commits January 13, 2026 16:59

Use typed integers and fallible enum parsing in block types

8e550f2

Add KeetaBlockBuilder and replace U128 with byte slices

ce141db

Add signatures to KeetaBlock

0f2914b

ezraripps reviewed Jan 14, 2026

View reviewed changes

Add multisig signer types for V2 blocks

82e515f

mamonet added 9 commits January 15, 2026 15:48

Add vote types and separate rate/value swap types

880d5d2

Add DER encoding/decoding support with derive macros

711bbf7

Add test coverage

27650cf

Export vote and certificate types from lib.rs

032f569

Add KeetaBlock DER encoding/decoding with SDK compatibility tests

4135c36

Fix clippy expect_fun_call warnings in SDK compat tests

2bdcd25

Add multisig signer iteration support with SignersIter

d3e8baf

Fix clippy vec_init_then_push warning in multisig test

0ca1272

Embed test samples and add malformed input tests

c78763f

ezraripps requested review from ezraripps, rkeene and sephynox January 21, 2026 18:25

mamonet added 2 commits January 21, 2026 19:33

Fix clippy useless_vec warning in x509 utils test

883d2cc

Fix rustdoc warnings for bracket notation in docs

8822860

rkeene reviewed Jan 21, 2026

View reviewed changes

mamonet added 5 commits January 22, 2026 15:24

Replace manual DER parsing with SliceReader in SignersIter

2881b80

Add extract_operations_slice for block operations parsing

3a34af0

Add keetanetwork-permissions crate with permission bit definitions

10a5c8c

Add keetanetwork-permissions to workspace members

374bba1

Add metadata module and consolidate permissions into keetanetwork-block

9d76887

	pub const SECP256R1: u8 = 0x02;
	pub const SECP256R1: u8 = 0x06;

Conversation

mamonet commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mamonet Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sephynox Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mamonet commented Jan 11, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mamonet Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rkeene commented Jan 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mamonet Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mamonet commented Jan 10, 2026 •

edited

Loading

mamonet Jan 10, 2026 •

edited

Loading

sephynox Jan 13, 2026 •

edited

Loading

mamonet Jan 14, 2026 •

edited

Loading

mamonet Jan 13, 2026 •

edited

Loading

mamonet commented Jan 19, 2026 •

edited

Loading