UI Updates to Tap Detail View by johnnyruz · Pull Request #124 · Kegbot/kegbot-android

johnnyruz · 2020-05-18T17:48:37Z

Here are some updates I made a while ago to add some additional information (ABV/IBU) to the main tap display, as well as clean up some text spacing issues I was experiencing on my Acer A210.

There are a couple things going on with that tablet, mainly that the Android system text size defaults to "Large" which throws things off. Setting to "Normal" looks better but I still adjusted the size so that values are still readable but don't overflow their containers.

Would love to have some additional testing and review on newer devices, almost certainly with higher resolutions.

…ption to enable/disable

…r210 10.1")

…Done button from being cut off

patfreeman

I like getting the ABV and IBU on the screen. I'm open to suggestions on the language of those stats.
Some minor sizing helped make it look better.
The other layout changes need some work to look good on more devices.

patfreeman · 2020-05-19T00:08:32Z

kegtab/src/main/res/xml/settings_general.xml

+        <CheckBoxPreference
+            android:title="Show ABV when zero"
+            android:key="config:ABV_DISPLAY_WHEN_ZERO"
+            android:summaryOn="ABV will be displayed even when zero"
+            android:summaryOff="ABV will not be displayed when zero"
+            android:defaultValue="false">
+        </CheckBoxPreference>
+        <CheckBoxPreference
+            android:title="Show IBU when zero"
+            android:key="config:IBU_DISPLAY_WHEN_ZERO"
+            android:summaryOn="IBU will be displayed even when zero"
+            android:summaryOff="IBU will not be displayed when zero"
+            android:defaultValue="false">
+        </CheckBoxPreference>
+        <CheckBoxPreference
+            android:title="Show Tap Notes"
+            android:key="config:DISPLAY_TAP_NOTES"
+            android:summaryOn="Tap Notes will be displayed if available"
+            android:summaryOff="Tap Notes will not be displayed"
+            android:defaultValue="true">
+        </CheckBoxPreference>


This should probably be in the User Interface section of settings_kegerator.xml

Hmm, yeah I could see it making more sense on that page since that grouping (currently only one item) controls the tap detail display. Makes sense under the title of "Look and Feel", but maybe that should just be "Units" and the UI settings are under Kegerator > User Interface

patfreeman · 2020-05-19T00:21:59Z

kegtab/src/main/res/values/styles.xml

+        <item name="android:layout_height">wrap_content</item>
+        <item name="android:ellipsize">end</item>
+        <item name="android:singleLine">true</item>
+        <item name="android:textSize">22sp</item>


Was a touch too big for the default font sizes on my nexus 7. ABV and IBU lines bled together. 20sp looked better to me.

Sounds good, should also look fine on my 10" tablet and will give just a bit extra room for Beer Name/Tap Name. Definitely tricky trying to get a solution that works on all screen sizes. I need to refresh my memory on the units 'sp'/'dip'. Maybe there's a better way ensure consistent UI.

sp is supposed to be the better way at least according to what android studio just told me. :)

patfreeman · 2020-05-19T00:43:34Z

kegtab/src/main/java/org/kegbot/app/TapStatusFragment.java

+    // Find ABV and IBU values
+    final String abv = String.valueOf(keg.getBeverage().getAbvPercent());
+    if(mCore.getConfiguration().getAbvVisibleWhenZero()) {
+      abvText.setText("ABV: " + abv + "%");


I'd personally prefer it to read more naturally, like 6.7% ABV

I could agree with that, thoughts on also flipping the IBU display? I think having both labels as a prefix or suffix would look best vs. having one as 6.7% ABV and the other IBU: 50. EDIT: Missed the comment below!

patfreeman · 2020-05-19T00:45:13Z

kegtab/src/main/java/org/kegbot/app/TapStatusFragment.java

+    if(mCore.getConfiguration().getAbvVisibleWhenZero()) {
+      abvText.setText("ABV: " + abv + "%");
+    } else{
+      abvText.setText(keg.getBeverage().getAbvPercent() == 0 ? "" : "ABV: " + abv + "%");


This should probably just set the visibility to GONE. abvText.setVisibility(View.GONE);

Agreed, fixing

patfreeman · 2020-05-19T00:45:30Z

kegtab/src/main/java/org/kegbot/app/TapStatusFragment.java

+    if(mCore.getConfiguration().getIbuVisibleWhenZero()){
+      ibuText.setText("IBU: " + ibu);
+    } else{
+      ibuText.setText(keg.getBeverage().getIbu() == 0 ? "" : "IBU: " + ibu);


This should probably just set the visibility to GONE. ibuText.setVisibility(View.GONE);

Agreed, fixing

patfreeman · 2020-05-19T00:45:57Z

kegtab/src/main/java/org/kegbot/app/TapStatusFragment.java

+
+    final String ibu = String.valueOf(Math.round(keg.getBeverage().getIbu()));
+    if(mCore.getConfiguration().getIbuVisibleWhenZero()){
+      ibuText.setText("IBU: " + ibu);


I'd personally prefer it to read more naturally, like 17 IBUs

patfreeman · 2020-05-19T00:47:45Z

kegtab/src/main/res/layout/tap_detail_loaded.xml

+        android:layout_height="wrap_content"
+        android:layout_below="@+id/tapStatsBadges"
+        android:layout_centerHorizontal="true"
+        android:layout_margin="16dp"


This feels like a huge margin.

patfreeman · 2020-05-19T00:47:57Z

kegtab/src/main/res/layout/tap_detail_loaded.xml

+        android:layout_centerHorizontal="true"
+        android:layout_margin="16dp"
+        android:layout_marginTop="2dip"
+        android:padding="16dp"


and padding.

Looked ok on my tablet...but looks better with it eliminated/reduced! Fixed!

patfreeman · 2020-05-19T00:50:49Z

kegtab/src/main/res/layout/pour_in_progress_activity.xml

    <!-- Right box: Camera Preview & Controls -->

-    <LinearLayout
+    <RelativeLayout


This change hide the Done Pouring button.

Aligned camera view to bottom but reverted changes to Done Button/Image/Shout text to maintain visibility on smaller tablet screens.

mik3y · 2020-05-21T23:07:22Z

just let me if/when this is ready to go, gents!

…on smaller tablet screens

mik3y · 2020-06-28T14:29:08Z

hey gents! just checking in here, does this still need work? - take your time if so, just making sure you're not waiting on me.

John Ruzick added 4 commits May 18, 2020 11:08

Add ABV/IBU text to Tap Details

de64fab

Show tap/beverage notes on the tap details page, with configuration o…

914e7cc

…ption to enable/disable

Make badge text smaller to improve fit on some tablets (tested on Ace…

5cdd401

…r210 10.1")

(Issue Kegbot#102) - Clean up layout on Pour In Progress to prevent …

e9282ec

…Done button from being cut off

patfreeman suggested changes May 19, 2020

View reviewed changes

First updates based on patfreeman suggestions

e62fc7b

Reverse layout changes to pour in progress screen, did not look good …

7a7b1e8

…on smaller tablet screens

Conversation

johnnyruz commented May 18, 2020

Uh oh!

patfreeman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnnyruz May 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mik3y commented May 21, 2020

Uh oh!

mik3y commented Jun 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johnnyruz May 19, 2020 •

edited

Loading