mpu6050 read data by time with kthread wariant#46
Open
dmytrokirtoka wants to merge 1 commit into
Open
Conversation
added ring buffer with 10 elm added module parameter rate, default is 1000 msec added kthread for periodic read data from device by delay
an1kh
approved these changes
Dec 12, 2017
an1kh
left a comment
an1kh
left a comment
Contributor
There was a problem hiding this comment.
Have no objections to idea and implementation. But the code has some formatting issues like spacing. Please fix them and merge.
I'll go ahead and ack.
AleksandrBulyshchenko
requested changes
Jan 10, 2018
AleksandrBulyshchenko
left a comment
AleksandrBulyshchenko
left a comment
Collaborator
There was a problem hiding this comment.
Kthread usage seems OK,
But commit message requires rewriting and checkpatch issues should be fixed.
Anyway AFAIU, this PR isn't going to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added ring buffer with 10 elm
added module parameter rate, default is 1000 msec
added kthread for periodic read data from device by msleep delay.