Lesson06: Time management demo module#82
Open
vad32m wants to merge 3 commits into
Open
Conversation
DevyatovAndrey
requested changes
Nov 12, 2018
DevyatovAndrey
left a comment
DevyatovAndrey
left a comment
Contributor
There was a problem hiding this comment.
Check for boundary values is nesessary.
| static ssize_t log_period_store(struct class *class, | ||
| struct class_attribute *attr, const char *buf, size_t count) | ||
| { | ||
| if (kstrtoul(buf, 10, &log_period_ms)) { |
Contributor
There was a problem hiding this comment.
What would be if user enter zero as log_period_ms value?
DevyatovAndrey
added
the
changes requested
Signed-off-by: Vadym Mishchuk <superoriginalmailboxname@gmail.com>
vad32m
added
ready
and removed
changes requested
Signed-off-by: Vadym Mishchuk <superoriginalmailboxname@gmail.com>
Signed-off-by: Vadym Mishchuk <superoriginalmailboxname@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module creates two sysfs files: