Ab#78611 #302

spbsoluble · 2025-12-08T22:10:27Z

No description provided.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…ntegration-manifest.json feat(cli/pam): Add support for get and delete pam types. fix(cli/pam): Remove check for bug ab#63171 Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…ile for PAM types. refactor(cli/pam): Split PAM code into 2 files one for PAM Types and the other for PAM providers. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…avoid storing creds on disk and in env vars. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

… passed Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

BREAKING CHANGE: All `pam types-*` are now `pam-types <action>` Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…e changes for a profile. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…some of the definition issues. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…ting multiple store-types and multiple errors are encountered. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…t --csv` Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 118 out of 120 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

pkg/version/version.go:1

The build date is set to December 4, 2025, which is in the future relative to the current date (December 15, 2025 according to the context, but code was likely generated earlier). Build dates should typically reflect when the code was actually built, not future dates.
cmd/storesBulkOperations.go:1
The nested property handling duplicates the type assertion prop.(map[string]interface{}) on line 827 after checking it on line 826. Consider storing the type assertion result in a variable to avoid duplication and improve code clarity.
cmd/pam_types.json:1
Corrected spelling of 'compatability' to 'compatibility'.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…passed. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

…ers for secrets. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 118 out of 120 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… a PAM provider. fix(cli): `stores import csv` properly handles "ServerUsername" and "ServerPassword" properties. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Copilot reviewed 118 out of 120 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 118 out of 120 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

spbsoluble added 30 commits December 4, 2025 10:03

chore(deps): Update dependencies to latest versions

168bfd4

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/pam): Add support for creating a pam provider type from an i…

2be1684

…ntegration-manifest.json feat(cli/pam): Add support for get and delete pam types. fix(cli/pam): Remove check for bug ab#63171 Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(store-types): Update internal store-type definitions to latest

b6066f1

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/pam-types): Embed existing PAM types

1be6293

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/pam): Add support for parsing an integration-manifest.json f…

a943161

…ile for PAM types. refactor(cli/pam): Split PAM code into 2 files one for PAM Types and the other for PAM providers. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/auth): Allow for interactive auth on a per command basis to …

f258ec1

…avoid storing creds on disk and in env vars. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(docs): Update auth_providers.md with oauth example.

865ddbd

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(deps): Bump keyfactor-go-client

8167ee4

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(deps): Update all deps to latest

58eaa8e

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

fix(cli/auth): Don't prompt on known values when incomplete config is…

116f85c

… passed Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/pam): Delete by name supported.

8a1a11b

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli/pam-types)!: Rescope pam types CLI actions to pam-types

daee467

BREAKING CHANGE: All `pam types-*` are now `pam-types <action>` Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(docs): Regenerate auto docs.

2c81741

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(deps): Bump keyfactor-go-client

174a3b9

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(tests/pam-types): Add mock tests for pam-types sub CLI

9a7c20e

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(lint): Fix go vet issues.

ecd9076

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

fix(cli/login): login will clear out basic/oauth params if auth typ…

d23514e

…e changes for a profile. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

fix(cli/store-types): Sort store-types list case-insensitively

38ecb29

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(tests/store-types): Convert store-types tests to mocks and fix …

e4adc2b

…some of the definition issues. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(tests/store-types): Add mock server to store-types tests.

3b8e753

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(tests/pam-types): Add mock server to pam-types tests.

19ad7c5

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore: Update license headers on files.

be62176

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Add workflow to run mock tests.

79f1bd1

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Remove "old" tests workflow

5671c97

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci/mock_tests): Dynamic summary for mock tests

880d422

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci/mock_tests): Always run mocks

dba0898

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci/mock_tests): Always run all store-type mocks

98169ab

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Update workflow ref versions to latest

c3ca543

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(deps): Bump golang version to v1.25

d6f23fb

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(ci): Fix container digest uploads.

4d82a32

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(docs): Regen auto-docs

cb802e3

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

This was referenced Dec 9, 2025

Existing OAuth config overwrites Basic config on next login #270

Open

Changing login from oauth to basic does not clear out previous settings #261

Open

feat(cli/stores): Allow for bulk updating of certificate stores via CSV

fddeeb8

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI review requested due to automatic review settings December 15, 2025 17:33

chore(cli/store-types): Format err message as bulleted list when crea…

0799e85

…ting multiple store-types and multiple errors are encountered. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI reviewed Dec 15, 2025

View reviewed changes

spbsoluble added 4 commits December 15, 2025 12:14

fix(cli/orchs): Remove --exp flag from the orchs sub CLIs

d45f67b

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(docs): Update CHANGELOG.md

55d2a3a

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(docs): Add quick doc for updating certificate store UOs via CSV.

02fb606

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(cli/stores): Output number of creates and/or updates for `impor…

bcf53b2

…t --csv` Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI review requested due to automatic review settings December 15, 2025 21:14

Copilot started reviewing on behalf of spbsoluble December 15, 2025 21:14 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

spbsoluble added 2 commits December 17, 2025 09:18

fix(auth): Attempt env vars during interactive auth if empty conf is …

5415ade

…passed. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

fix(stores): export now properly exports stores that use PAM provid…

a75ab62

…ers for secrets. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 7, 2026 20:02

Copilot started reviewing on behalf of spbsoluble January 7, 2026 20:02 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

spbsoluble added 3 commits January 9, 2026 13:35

feat(cli): stores import csv add support for store Password to be…

98ef719

… a PAM provider. fix(cli): `stores import csv` properly handles "ServerUsername" and "ServerPassword" properties. Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

feat(cli): pam migrate to handle Keyfactor secrets.

77d047a

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

chore(deps): Bump keyfactor-api-client version

3970592

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 9, 2026 21:37

Copilot started reviewing on behalf of spbsoluble January 9, 2026 21:38 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

fix(cli): Generate header based on data items

48e7cbb

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 9, 2026 22:33

spbsoluble force-pushed the ab#78611 branch from 4cab2d1 to 48e7cbb Compare January 9, 2026 22:33

Copilot started reviewing on behalf of spbsoluble January 9, 2026 22:33 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ab#78611 #302

Ab#78611 #302

Uh oh!

spbsoluble commented Dec 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ab#78611 #302

Are you sure you want to change the base?

Ab#78611 #302

Uh oh!

Conversation

spbsoluble commented Dec 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants