Merged
Conversation
24288d8 to
c5a8f73
Compare
cf5dae7 to
5972a57
Compare
bashbaug
approved these changes
May 27, 2024
Contributor
bashbaug
left a comment
There was a problem hiding this comment.
LGTM, just a few minor questions, thanks!
Member
|
Latest commits:
|
Contributor
|
Merging as discussed in the June 25th teleconference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Werror//WXis enabled in CICMakeLists.txtto be able to produce a binary Debian package usingcpack.presubmitworkflow now.git-clang-format.v*tagDebSourcePkg.cmakewhich is intended to run in CMake script mode. This script generates thedebian/control,debian/changelogand ``debian/rules` files which are required to build a Debian source package.This PR is considered to be complete, albeit review remarks and/or changes to related PRs might warrant minor updates.