API dump: print XrPath values#606
Open
xytovl wants to merge 1 commit into
Open
Conversation
Collaborator
|
An issue (number 2759) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2759 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
Contributor
|
Hey this looks pretty handy. Any way you could print both the atom value and the string? |
Author
|
If we want to have both id and value, options are:
<details class="data">
<summary>...</summary>
<div class="data">
<div class="type">int</div>
<div class="var">id</div>
<div class="val">0</div>
</div>
<div class="data">
<div class="type">string</div>
<div class="var">value</div>
<div class="val">some value</div>
</div>
</details>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API dump shows numeric values of an XrPath, which are not convenient to track what is being called.
This change calls
xrPathToStringon each value and prints the result.It appears that
PathToStringalways returns XR_SUCCESS through the dispatch table, so I can't handle invalid paths correctly.Sample new output: