Generate asm directly when cross-compiling #1839
Conversation
`-save-temps=obj` breaks on availability checks when compiling for visionOS. There is no need to compile the executable when cross-compiling so instead we pass in '-S' to just generate the assembly.
|
Author osy not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author osy not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
I will need more time to review this properly - cross compilation isn't tested regularly, so there isn't a test environment setup (as in, I get to pull out my raspberry pi 😄 )
On first review, this looks like a good change. From what I recall, -save-temps=obj was used to enable the parse_asm_values.py script, but if -S works and doesn't differ between GNU, clang & AppleClang then I'm all for it.
|
CI Vulkan-Loader build queued with queue ID 616179. |
|
CI Vulkan-Loader build # 3359 running. |
|
CI Vulkan-Loader build # 3359 passed. |
|
Author osy not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author osy not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 622623. |
|
CI Vulkan-Loader build # 3370 running. |
|
Was able to pull the changes down and do a quick test that everything still worked. I found that Ninja didn't like the way the custom command was defined (BYPRODUCTS is unnecessary with the change) so went ahead and fixed it. Let me know if that change breaks you before I merge it. |
Fixes issue with multiple defined outputs for gen_defines.asm, and uses more idiomatic patterns for generated files.
|
Author osy not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author osy not on autobuild list. Waiting for curator authorization before starting CI build. |
|
Oops, I force pushed to fix a basic issue where the dependency between asm_offset and running the gen_defines.asm script was missing. Apologies! |
|
CI Vulkan-Loader build queued with queue ID 622644. |
|
CI Vulkan-Loader build # 3371 running. |
|
CI Vulkan-Loader build # 3371 passed. |
|
@charles-lunarg I tested the commit and it works fine for me, thanks |
4 participants
-save-temps=objbreaks on availability checks when compiling for visionOS. There is no need to compile the executable when cross-compiling so instead we pass in '-S' to just generate the assembly.