-
Notifications
You must be signed in to change notification settings - Fork 781
Filesystem create directories #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filesystem create directories #1214
Conversation
gary-sweet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing almost immediate crashes for me in batch mode.
Need some time to investigate.
270923b
c1c7ce3 to
270923b
Compare
|
Force pushed a rebase.
@gary-sweet possibly something setting temp and external storage incorrectly on your system? I ran batch mode again on my Mac and it worked correctly. Ill try again on a linux machine later |
The rebase on main seems to have fixed the problem (which was only happening in release builds). Thanks |
|
Hey @SaschaWillems @asuessenbach would you be able to re-review please? Approvals where invalidated after rebasing |
|
Merging - 3 approvals |
Description
An alternate approach to fixing the
create_pathbug in the legacy filesystemGeneral Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: