Skip to content

Conversation

@tomadamatkinson
Copy link
Contributor

Description

An alternate approach to fixing the create_path bug in the legacy filesystem

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@tomadamatkinson tomadamatkinson mentioned this pull request Nov 4, 2024
13 tasks
asuessenbach
asuessenbach previously approved these changes Nov 5, 2024
@SaschaWillems SaschaWillems self-requested a review November 16, 2024 09:00
SaschaWillems
SaschaWillems previously approved these changes Nov 16, 2024
Copy link
Contributor

@gary-sweet gary-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing almost immediate crashes for me in batch mode.
Need some time to investigate.

@tomadamatkinson tomadamatkinson force-pushed the filesystem-create-directories branch from c1c7ce3 to 270923b Compare November 19, 2024 10:53
@tomadamatkinson
Copy link
Contributor Author

Force pushed a rebase.

This is causing almost immediate crashes for me in batch mode.

@gary-sweet possibly something setting temp and external storage incorrectly on your system? I ran batch mode again on my Mac and it worked correctly. Ill try again on a linux machine later

@gary-sweet
Copy link
Contributor

Force pushed a rebase.

This is causing almost immediate crashes for me in batch mode.

@gary-sweet possibly something setting temp and external storage incorrectly on your system? I ran batch mode again on my Mac and it worked correctly. Ill try again on a linux machine later

The rebase on main seems to have fixed the problem (which was only happening in release builds). Thanks

@tomadamatkinson
Copy link
Contributor Author

tomadamatkinson commented Nov 19, 2024

Hey @SaschaWillems @asuessenbach would you be able to re-review please?

Approvals where invalidated after rebasing

@SaschaWillems SaschaWillems self-requested a review November 19, 2024 16:44
@marty-johnson59
Copy link
Contributor

Merging - 3 approvals

@marty-johnson59 marty-johnson59 merged commit 4838e02 into KhronosGroup:main Nov 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants