Skip to content

Conversation

@gnl21
Copy link

@gnl21 gnl21 commented Dec 15, 2025

Giving an instance name to a buffer_reference declaration also declares a block with that type, which does not seem to have been the intention. The block is never given a binding (which should not be valid, but see KhronosGroup/glslang#4128) and is never used in the shader, so remove the declaration. There should be no functional change to the sample (verified on Broadcom's implementation).

  • My code follows the coding style
  • I have reviewed file licenses
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • My changes do not add any regressions
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms

Giving an instance name to a buffer_reference declaration also declares
a block with that type, which does not seem to have been the intention.
@asuessenbach
Copy link
Contributor

The copyright message should look like this now:
Copyright (c) 2021-2025 Holochip Corporation

Besides that: looks good.

@gnl21
Copy link
Author

gnl21 commented Dec 16, 2025

The copyright message should look like this ...

Done, thanks.

Copy link
Collaborator

@gpx1000 gpx1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants